Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter dialog does not duplicate filter term #1705

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Oct 21, 2019

Checklist:

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #1705 into gsa-9.0 will decrease coverage by 0.15%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-9.0    #1705      +/-   ##
===========================================
- Coverage    47.38%   47.23%   -0.16%     
===========================================
  Files         1047     1047              
  Lines        24139    24139              
  Branches      6747     6746       -1     
===========================================
- Hits         11438    11401      -37     
- Misses       11561    11592      +31     
- Partials      1140     1146       +6
Impacted Files Coverage Δ
gsa/src/web/components/powerfilter/filterdialog.js 1.4% <0%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <100%> (ø) ⬆️
gsa/src/web/pages/audits/listpage.js 76.92% <0%> (-15.39%) ⬇️
...rc/web/components/provider/subscriptionprovider.js 87.5% <0%> (-12.5%) ⬇️
gsa/src/web/entities/container.js 42.3% <0%> (-11.19%) ⬇️
gsa/src/web/pages/tlscertificates/component.js 10.34% <0%> (-0.37%) ⬇️
gsa/src/web/pages/audits/component.js 38.51% <0%> (-0.11%) ⬇️
gsa/src/web/pages/credentials/dialog.js 2.8% <0%> (ø) ⬆️
gsa/src/web/components/dashboard/display/utils.js 75% <0%> (ø) ⬆️
...a/src/web/pages/tickets/dashboard/statusdisplay.js 30% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c43c91...14e3b42. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review October 21, 2019 14:15
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a CHANGELOG.md entry too?

@bjoernricks bjoernricks merged commit afe198a into greenbone:gsa-9.0 Oct 22, 2019
@saberlynx saberlynx deleted the filter-merge branch November 11, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants