Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting user default filter in report results #1699

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Fix setting user default filter in report results #1699

merged 2 commits into from
Oct 17, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp
Fix setting defaultFilter for report results
899598f 
Clicking the "reset to default filter" button in the powerfilter of the 
report detailspage loads and sets the userSettingsDefaultFilter for 
results. If none is set, it falls back to the DEFAULT_FILTER set on the 
detailspage.
@swaterkamp swaterkamp requested a review from a team October 17, 2019 10:07
@swaterkamp swaterkamp self-assigned this Oct 17, 2019
bjoernricks
bjoernricks approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1699 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1699      +/-   ##
===========================================
- Coverage    39.52%   39.52%   -0.01%     
===========================================
  Files          965      965              
  Lines        22120    22122       +2     
  Branches      6230     6230              
===========================================
  Hits          8743     8743              
- Misses       12111    12113       +2     
  Partials      1266     1266
Impacted Files Coverage Δ
gsa/src/web/pages/reports/detailspage.js 3.07% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4397958...a91e181. Read the comment docs.

@bjoernricks bjoernricks merged commit d48eba3 into greenbone:gsa-8.0 Oct 17, 2019
@swaterkamp swaterkamp deleted the FixDefaultFilter8 branch October 17, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaterkamp @bjoernricks