Load "small" before "full" report #1697
Conversation
swaterkamp
requested review from
bjoernricks and
timopollmeier
as code owners
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1697 +/- ##
===========================================
- Coverage 39.52% 39.52% -0.01%
===========================================
Files 965 965
Lines 22095 22120 +25
Branches 6237 6230 -7
===========================================
+ Hits 8734 8743 +9
- Misses 12098 12111 +13
- Partials 1263 1266 +3
Continue to review full report at Codecov.
|
They can be still loading and should not be required
swaterkamp
force-pushed
the
ReportDetailsPerformance8
branch
from
e66282f to
3a7fb5c
Compare
| @@ -181,8 +183,8 @@ class ReportEntitiesContainer extends React.Component { | |||
|
|
|||
| ReportEntitiesContainer.propTypes = { | |||
| children: PropTypes.func, | |||
| counts: PropTypes.counts.isRequired, | |||
| entities: PropTypes.array.isRequired, | |||
| counts: PropTypes.oneOfType([PropTypes.counts, PropTypes.object]).isRequired, | |||
There was a problem hiding this comment.
Why should an object be passed as counts here?
There was a problem hiding this comment.
I need an object instead of counts, because if I pass a new CollectionCount() its construction sets all fields to 0 resulting in faulty information on the detailspage (it will tell me that the report is empty instead of showing Loading).
There was a problem hiding this comment.
Why not passing undefined instead? undefined has a clear meaning.
There was a problem hiding this comment.
For example in ResultsTab I would have to check again, if it's undefined when calling counts.filtered or counts.all. in order not to have to add several tests like that i just pass an empty object.
There was a problem hiding this comment.
you could init the counts instead when passing undefined
{counts = {}} = props
Seems to be much cleaner to me :-)
There was a problem hiding this comment.
In ReportEntitiesContainer i would still have to accept CollectionCount and Object then.
There was a problem hiding this comment.
ok. i'll take a look after the pr is merged.
swaterkamp
force-pushed
the
ReportDetailsPerformance8
branch
from
7a43411 to
2219310
Compare
Checklist: