Fix comparing filters #1677
Merged
Fix comparing filters #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not crash if null is passed as a filter to a filter method e.g. and or merge. It may possible now that the filter is null additionally to undefined.
The method has been made public a while ago. Therefore update description and move it to the right place. Also add a small set of tests for the merge method.
If we need to use the function at more places it should be very fast. Therefore avoid creating a new stack due to calling another function internally.
We need to check for null now when using filter methods.
Codecov Report
@@ Coverage Diff @@
## gsa-9.0 #1677 +/- ##
===========================================
+ Coverage 46.98% 46.98% +<.01%
===========================================
Files 1047 1047
Lines 24082 24084 +2
Branches 6712 6713 +1
===========================================
+ Hits 11314 11316 +2
Misses 11620 11620
Partials 1148 1148
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid and fix several issues with filter being null now.
Checklist: