Decide whether to default to full and fast scan config (task dialog)

[saberlynx]

Summary of changes:

• moved handleScannerChange out of ScannerSelect
• Refactored ScannerSelect into function
• Added state variables configType and prevConfigType, and calculate/update them in handleScannerChange, and upon onScanConfigChange.

Expected behavior:

• Changing between scanners of the same config type should not change displayed scan config selection
• Edit dialog should show correct scan config
• Scan config should default to "Full and Fast" when 1. creating a new task 2. changing configType from something else TO openvas config type.

Checklist:

• [] Tests
• CHANGELOG Entry

[codecov]

Codecov Report

Merging #1671 into gsa-9.0 will decrease coverage by 0.01%.
The diff coverage is 2.94%.

@@             Coverage Diff             @@
##           gsa-9.0    #1671      +/-   ##
===========================================
- Coverage       47%   46.98%   -0.02%     
===========================================
  Files         1047     1047              
  Lines        24072    24082      +10     
  Branches      6733     6712      -21     
===========================================
  Hits         11314    11314              
- Misses       11612    11620       +8     
- Partials      1146     1148       +2

Impacted Files	Coverage Δ
gsa/src/web/pages/tasks/dialog.js	4.91% <2.94%> (-0.44%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fd0bf...943dc70. Read the comment docs.

[bjoernricks]

I tend to say the scan config and scanner state must be move one layer upwards into the taskcomponent but maybe I am wrong and it can be solved in the dialog too.

The state of the scanner type and scan config should be initialized via useEffect and afterwards the state should only be updated via change handlers. Maybe we should introduce one config_id variable for each purpose. E.g. currentOspdConfigId currentOpenvasConfigId or something like that. Or use an object currentConfigIds = {openvas: ..., osp: ..., other: ...}

[swaterkamp]

I was thinking to use the task component's state to control the dialog content (scanner and scan config types), but I think I haven't been clear about that, sorry.

[bjoernricks]

Looks very good! Just one small change and could you update your PR to be against the gsa-9.0 branch? It should be included in GOS 6 already.