Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed auth_method preselection for user dialog #1661

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Fixed auth_method preselection for user dialog #1661

merged 3 commits into from
Oct 2, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Oct 2, 2019 •
edited
Loading

Checklist:

@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #1661 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1661      +/-   ##
===========================================
- Coverage    37.65%   37.64%   -0.01%     
===========================================
  Files          966      966              
  Lines        22114    22116       +2     
  Branches      6210     6212       +2     
===========================================
  Hits          8326     8326              
- Misses       12463    12465       +2     
  Partials      1325     1325
Impacted Files Coverage Δ
gsa/src/web/pages/users/dialog.js 1.56% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a339bf...10e27a8. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review October 2, 2019 08:03
@saberlynx saberlynx requested a review from a team October 2, 2019 08:03
bjoernricks
bjoernricks approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why the correct authMethod wasn't passed to the dialog on opening but this pr should fix the behavior 👍

@bjoernricks bjoernricks merged commit be903dc into greenbone:gsa-8.0 Oct 2, 2019
@saberlynx saberlynx deleted the radius-ldap-login branch October 2, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks