Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterprovider improvements #1653

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Filterprovider improvements #1653

merged 3 commits into from
Oct 1, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Oct 1, 2019

Handle errors safely

Checklist:

@bjoernricks bjoernricks marked this pull request as ready for review October 1, 2019 09:32
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small quantitative adjustment :)

@bjoernricks bjoernricks requested a review from swaterkamp October 1, 2019 09:44
swaterkamp
swaterkamp previously approved these changes Oct 1, 2019
In some cases there might not be a default settings filter. Therefore
check if loading the filter has an error and ignore it.
Ensure that the FilterProvider acts safely if the rows per page user
setting couldn't be loaded.
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #1653 into master will increase coverage by 0.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1653      +/-   ##
=========================================
+ Coverage   41.56%   42.4%   +0.83%     
=========================================
  Files        1048    1048              
  Lines       24063   24075      +12     
  Branches     6721    6702      -19     
=========================================
+ Hits        10002   10209     +207     
+ Misses      12757   12589     -168     
+ Partials     1304    1277      -27
Impacted Files Coverage Δ
gsa/src/web/entities/filterprovider.js 100% <100%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <100%> (ø) ⬆️
...rc/web/components/provider/subscriptionprovider.js 47.05% <0%> (+8.82%) ⬆️
gsa/src/web/pages/audits/listpage.js 76.92% <0%> (+15.38%) ⬆️
gsa/src/web/entities/withEntitiesContainer.js 95.45% <0%> (+18.18%) ⬆️
gsa/src/web/pages/policies/listpage.js 100% <0%> (+18.18%) ⬆️
gsa/src/web/entities/container.js 33.21% <0%> (+31.46%) ⬆️
gsa/src/web/components/powerfilter/powerfilter.js 49.39% <0%> (+43.37%) ⬆️
gsa/src/web/entities/page.js 69.56% <0%> (+63.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfdc841...f304d49. Read the comment docs.

@swaterkamp swaterkamp merged commit fdc49ac into greenbone:master Oct 1, 2019
@bjoernricks bjoernricks deleted the filterprovider-improvements branch October 1, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants