-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filterprovider improvements #1653
Filterprovider improvements #1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small quantitative adjustment :)
In some cases there might not be a default settings filter. Therefore check if loading the filter has an error and ignore it.
Ensure that the FilterProvider acts safely if the rows per page user setting couldn't be loaded.
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
=========================================
+ Coverage 41.56% 42.4% +0.83%
=========================================
Files 1048 1048
Lines 24063 24075 +12
Branches 6721 6702 -19
=========================================
+ Hits 10002 10209 +207
+ Misses 12757 12589 -168
+ Partials 1304 1277 -27
Continue to review full report at Codecov.
|
Handle errors safely
Checklist: