Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clone and verify functionalities for ReportFormats #1650

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #1650 into gsa-8.0 will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1650      +/-   ##
===========================================
+ Coverage     37.6%   37.64%   +0.03%     
===========================================
  Files          966      966              
  Lines        22125    22103      -22     
  Branches      6234     6205      -29     
===========================================
  Hits          8320     8320              
+ Misses       12480    12459      -21     
+ Partials      1325     1324       -1
Impacted Files Coverage Δ
gsa/src/web/pages/reportformats/component.js 1.88% <ø> (+0.16%) ⬆️
gsa/src/web/pages/reportformats/listpage.js 50% <ø> (+11.53%) ⬆️
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (+2.08%) ⬆️
gsa/src/gmp/commands/reportformats.js 24.13% <ø> (+7.06%) ⬆️
gsa/src/web/pages/reportformats/row.js 40% <ø> (ø) ⬆️
gsa/src/web/components/dashboard/dashboard.js 8.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841c623...a7f4953. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed code is the best code 😁

@bjoernricks bjoernricks merged commit f6cd414 into greenbone:gsa-8.0 Oct 1, 2019
@swaterkamp swaterkamp deleted the RemoveCloneVerifyForRF branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants