Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TLS certificate filter type and default filter to GSA #1630

Merged
merged 4 commits into from
Sep 17, 2019

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Sep 16, 2019

Needs greenbone/gvmd#750 to work

Checklist:

@swaterkamp swaterkamp self-assigned this Sep 16, 2019
@swaterkamp swaterkamp marked this pull request as ready for review September 16, 2019 16:01
@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #1630 into master will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   42.33%   42.33%   +<.01%     
==========================================
  Files        1047     1047              
  Lines       23988    23992       +4     
  Branches     6660     6687      +27     
==========================================
+ Hits        10156    10158       +2     
- Misses      12593    12595       +2     
  Partials     1239     1239
Impacted Files Coverage Δ
gsa/src/web/pages/tlscertificates/listpage.js 37.5% <ø> (ø) ⬆️
gsa/src/web/pages/filters/component.js 8.33% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/dialog.js 30.76% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/filterpart.js 42.85% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/usersettingspage.js 3.46% <0%> (-0.03%) ⬇️
gsa/src/gmp/commands/users.js 26.78% <66.66%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100200d...711d1d2. Read the comment docs.

@swaterkamp swaterkamp merged commit 02a94da into greenbone:master Sep 17, 2019
@swaterkamp swaterkamp deleted the TlsCertFilter branch September 17, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants