Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feed status command #1628

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Fix feed status command #1628

merged 3 commits into from
Sep 13, 2019

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented Sep 13, 2019 •
edited by swaterkamp
Loading

Checklist:

@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #1628 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1628      +/-   ##
=========================================
+ Coverage   41.93%     42%   +0.06%     
=========================================
  Files        1044    1044              
  Lines       23955   23955              
  Branches     6610    6610              
=========================================
+ Hits        10046   10062      +16     
+ Misses      12663   12647      -16     
  Partials     1246    1246
Impacted Files Coverage Δ
gsa/src/gmp/commands/feedstatus.js 100% <100%> (+69.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1f751...77a79a4. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review September 13, 2019 11:52
bjoernricks
bjoernricks approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@bjoernricks bjoernricks merged commit 2934c3e into greenbone:master Sep 13, 2019
@sarahd93 sarahd93 deleted the feed_status_master branch September 13, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahd93 @bjoernricks @swaterkamp