Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable reload timer #1619

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Allow to disable reload timer #1619

merged 2 commits into from
Sep 9, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Sep 9, 2019

Add a function that handles setting the default reload interval to less
or equal to 0 to disable the reloading of entities. Update load and
getReloadInterval methods to stop loading if the calculated reload
interval is less or equal to 0.

Checklist:

Add a function that handles setting the default reload interval to less
or equal to 0 to disable the reloading of entities. Update load and
getReloadInterval methods to stop loading if the calculated reload
interval is less or equal to 0.
@bjoernricks bjoernricks marked this pull request as ready for review September 9, 2019 14:12
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #1619 into master will decrease coverage by <.01%.
The diff coverage is 46.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
- Coverage   41.91%   41.91%   -0.01%     
==========================================
  Files        1044     1044              
  Lines       23928    23939      +11     
  Branches     6610     6612       +2     
==========================================
+ Hits        10030    10034       +4     
- Misses      12652    12659       +7     
  Partials     1246     1246
Impacted Files Coverage Δ
gsa/src/web/pages/reports/detailspage.js 3.5% <16.66%> (+0.35%) ⬆️
gsa/src/web/entities/container.js 41.46% <66.66%> (-0.3%) ⬇️
gsa/src/web/entity/container.js 81.81% <70%> (-3.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf79a4a...f5254dc. Read the comment docs.

@swaterkamp swaterkamp merged commit 118db01 into greenbone:master Sep 9, 2019
@bjoernricks bjoernricks deleted the allow-to-disable-reload-timer branch September 9, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants