Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a loading timer for empty trash button #1604

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

saberlynx
Copy link
Contributor

Change the EmptyTrashButton to use LoadingButton instead, so users will have feedback when they empty the trashcan.
Checklist:

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #1604 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1604      +/-   ##
===========================================
- Coverage     37.4%   37.39%   -0.01%     
===========================================
  Files          966      966              
  Lines        22082    22087       +5     
  Branches      6208     6231      +23     
===========================================
  Hits          8259     8259              
- Misses       12496    12501       +5     
  Partials      1327     1327
Impacted Files Coverage Δ
gsa/src/web/pages/extras/trashcanpage.js 3.06% <10%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd6904...b9dd02e. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review September 3, 2019 09:14
@saberlynx saberlynx requested a review from a team September 3, 2019 09:14
@swaterkamp swaterkamp merged commit 474b7ff into greenbone:gsa-8.0 Sep 3, 2019
@saberlynx saberlynx deleted the empty-trash-loading branch September 12, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants