Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve policy detailspage and add tests for policy detailspage and details #1593

Merged
merged 6 commits into from
Aug 29, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review August 29, 2019 13:52
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1593 into master will increase coverage by 1.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1593     +/-   ##
=========================================
+ Coverage   37.97%   39.38%   +1.4%     
=========================================
  Files        1044     1044             
  Lines       23924    23902     -22     
  Branches     6596     6589      -7     
=========================================
+ Hits         9086     9414    +328     
+ Misses      13491    13178    -313     
+ Partials     1347     1310     -37
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/detailspage.js 53.19% <100%> (+21.27%) ⬆️
gsa/src/web/pages/policies/detailspage.js 100% <100%> (+66.66%) ⬆️
gsa/src/web/pages/permissions/component.js 15.78% <0%> (+14.47%) ⬆️
gsa/src/web/components/section/header.js 100% <0%> (+15.38%) ⬆️
gsa/src/web/pages/policies/component.js 30.93% <0%> (+29.66%) ⬆️
gsa/src/web/entity/permissions.js 42.02% <0%> (+31.88%) ⬆️
gsa/src/web/components/icon/listicon.js 100% <0%> (+33.33%) ⬆️
gsa/src/web/components/icon/manualicon.js 100% <0%> (+33.33%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffcf6d...a3e87a3. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Just one minor thing. I guess you can remove all the store.dispatch(entityActions.success('12345', policy)); calls. I don't think they are used nor required anymore.

@bjoernricks bjoernricks self-requested a review August 29, 2019 14:20
@bjoernricks bjoernricks merged commit baf32a5 into greenbone:master Aug 29, 2019
@sarahd93 sarahd93 deleted the detailspage_tests_master branch August 29, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants