Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable editing settings if permission is denied #1588

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp self-assigned this Aug 27, 2019
@swaterkamp swaterkamp marked this pull request as ready for review August 27, 2019 13:28
@swaterkamp swaterkamp requested a review from a team August 27, 2019 13:28
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question. Shouldn't we use a upper first letter for changelog entries? We don't enforce that yet.

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1588 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1588      +/-   ##
===========================================
- Coverage    37.48%   37.48%   -0.01%     
===========================================
  Files          965      965              
  Lines        21988    21993       +5     
  Branches      6126     6130       +4     
===========================================
  Hits          8243     8243              
- Misses       12434    12438       +4     
- Partials      1311     1312       +1
Impacted Files Coverage Δ
gsa/src/web/pages/usersettings/usersettingspage.js 3.49% <14.28%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4d3f1...1722456. Read the comment docs.

@swaterkamp
Copy link
Member Author

We should. I'll update the Changelog with the next PR that receives an entry

@swaterkamp swaterkamp merged commit 519c1ee into greenbone:gsa-8.0 Aug 27, 2019
@swaterkamp swaterkamp deleted the DisableEditingSettings branch February 20, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants