Extend TLS Certificate Assets #1578
Conversation
Use lowercase instead of camelCase
The long certificate names pushed the dropdown out of the dialog
swaterkamp
force-pushed
the
TLScertAssetMngmt
branch
from
4ccf293
to
2f84987
Compare
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 37.83% 37.81% -0.03%
==========================================
Files 1042 1043 +1
Lines 23795 23834 +39
Branches 6519 6533 +14
==========================================
+ Hits 9004 9013 +9
- Misses 13443 13473 +30
Partials 1348 1348
Continue to review full report at Codecov.
|
| <TableRow> | ||
| <TableData>{_('Activates')}</TableData> | ||
| <TableData> | ||
| {dateTimeWithTimeZone(entity.activationTime)} |
There was a problem hiding this comment.
Should use the DateTime component instead of the dateTimeWithTimeZone function
| <TableRow> | ||
| <TableData>{_('Expires')}</TableData> | ||
| <TableData> | ||
| {dateTimeWithTimeZone(entity.expirationTime)} |
There was a problem hiding this comment.
Same here. It should use the DateTime component instead of the dateTimeWithTimeZone function
| }; | ||
|
|
||
| const Details = ({entity, ...props}) => { | ||
| const showSourceBlock = [entity.sourceReportIds].reduce( |
There was a problem hiding this comment.
I don't get this line :-) Any reason why not using const showSourceBlock = entity.sourceReportIds.length > 0?
There was a problem hiding this comment.
Yes, it was late at night ;) In the beginning I just did for the showXY what we do in the menubar. Turned out to be much simpler but I didn't remove the leftover...
swaterkamp
force-pushed
the
TLScertAssetMngmt
branch
from
bbc0fc2
to
a024fee
Compare
Checklist: