(Multi)Select clickable area #1545
Conversation
Basically reverts greenbone#1296
When no item is selected the whole width of the Box can now be used to open the menu. Once one or more items are selected, the arrow button needs to be targeted
| @@ -69,7 +69,7 @@ const withLayout = (defaults = {}) => Component => { | |||
| basis: PropTypes.string, | |||
| flex: PropTypes.oneOf([true, 'column', 'row']), | |||
| grow: PropTypes.oneOfType([ | |||
| PropTypes.oneOf([true]), | |||
| PropTypes.oneOf([true, false]), | |||
There was a problem hiding this comment.
I don't think this is correct. Allowed are <Layout grow/> <Layout grow={true}/> <Layout grow="1"/> <Layout grow="0"/> <Layout grow={2}/> <Layout grow={0}/> but false shouldn't be used at the moment. I suppose it will work but syntactically a css flex-grow value of false doesn't exist. false is not handled within withLayout besides true which is converted to 1. So either withLayout should be adjusted to convert false into 0 or the expressions like grow={!itemsAreSelected} should be converted to `grow={itemsAreSelected == true ? 1 : 0}
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1545 +/- ##
===========================================
+ Coverage 37.52% 37.53% +<.01%
===========================================
Files 965 965
Lines 21955 21955
Branches 6136 6136
===========================================
+ Hits 8239 8241 +2
+ Misses 12406 12405 -1
+ Partials 1310 1309 -1
Continue to review full report at Codecov.
|
Checklist: