Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified filterdialogs for reports and vulnerabilities #1503

Merged
merged 6 commits into from
Jul 23, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jul 23, 2019

Checklist:

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #1503 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1503      +/-   ##
=========================================
- Coverage   37.11%   37.1%   -0.01%     
=========================================
  Files        1000     999       -1     
  Lines       22306   22288      -18     
  Branches     6136    6123      -13     
=========================================
- Hits         8278    8270       -8     
+ Misses      12715   12705      -10     
  Partials     1313    1313
Impacted Files Coverage Δ
gsa/src/web/pages/reports/filterdialog.js 33.33% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailsfilterdialog.js 20% <ø> (ø) ⬆️
gsa/src/web/pages/vulns/filterdialog.js 50% <40%> (-50%) ⬇️
gsa/src/web/components/layout/horizontalsep.js
gsa/src/web/pages/tasks/details.js 5.06% <0%> (+0.06%) ⬆️
gsa/src/web/pages/alerts/details.js 7.4% <0%> (+0.26%) ⬆️
gsa/src/web/pages/targets/details.js 10% <0%> (+0.32%) ⬆️
gsa/src/web/pages/notes/details.js 9.52% <0%> (+0.43%) ⬆️
gsa/src/web/pages/overrides/details.js 9.52% <0%> (+0.43%) ⬆️
gsa/src/web/pages/credentials/details.js 9.09% <0%> (+0.75%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b553975...e10f7be. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 23, 2019 10:18
@bjoernricks bjoernricks merged commit ea751e3 into greenbone:master Jul 23, 2019
@saberlynx saberlynx deleted the reportVulnsFilter branch July 24, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants