Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls_certificate commands to gsad #1455

Merged
merged 4 commits into from
Jun 26, 2019

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jun 25, 2019

This adds the commands create_tls_certificate, delete_tls_certificate,
get_tls_certificate, get_tls_certificates and save_tls_certificate
to gsad.

Checklist:

This adds the commands create_tls_certificate, delete_tls_certificate,
get_tls_certificate, get_tls_certificates and save_tls_certificate
to gsad.
@timopollmeier timopollmeier requested a review from a team June 25, 2019 15:16
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #1455 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
- Coverage   36.73%   36.72%   -0.01%     
==========================================
  Files         991      991              
  Lines       22191    22191              
  Branches     6088     6089       +1     
==========================================
- Hits         8151     8150       -1     
- Misses      12715    12716       +1     
  Partials     1325     1325
Impacted Files Coverage Δ
.../src/web/pages/scanconfigs/editnvtdetailsdialog.js 3.22% <0%> (-0.11%) ⬇️
gsa/src/gmp/models/nvt.js 98.75% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5b9cb...537e4ab. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am not really satisfied with the certificate_bin param name but because certificate has a different validation type it's fine.

@swaterkamp swaterkamp merged commit 000967f into greenbone:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants