Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Notes and Overrides of Results #1446

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Show Notes and Overrides of Results #1446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b63e8b
Always get details when requesting get_results
swaterkamp Jun 20, 2019
2e7d87f
Set correct result_id in NotesDialog
swaterkamp Jun 20, 2019
1cac90c
Update results command tests for details=1 param
swaterkamp Jun 20, 2019
4cafcc2
Update Changelog
swaterkamp Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Add tooltips to deactivated text fields in AlertDialog [#1269](https://github.com/greenbone/gsa/pull/1269)

### Changed
- Always load notes and overrides when getting results [#1446](https://github.com/greenbone/gsa/pull/1446)
- Disable some FileFields when RadioButton is not checked [#1430](https://github.com/greenbone/gsa/pull/1430)
- Change checkboxes for solution types to radio buttons [#1398](https://github.com/greenbone/gsa/pull/1398)
- Link to search in the manual for vulnerabilities [#1391](https://github.com/greenbone/gsa/pull/1391)
Expand All @@ -52,6 +53,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Cleanup get_report function in gsad [#1263](https://github.com/greenbone/gsa/pull/1263)

### Fixed
- Show notes and overrides for results and their icon indicator in results rows [#1446](https://github.com/greenbone/gsa/pull/1446)
- Display text if gvm-libs is build without LDAP and/or Radius support [#1437](https://github.com/greenbone/gsa/pull/1437)
- Fix sending related resources in permission.create() [#1432](https://github.com/greenbone/gsa/pull/1432)
- Don't allow bulk tagging vulnerabilities [#1429](https://github.com/greenbone/gsa/pull/1429)
Expand Down
2 changes: 2 additions & 0 deletions gsa/src/gmp/commands/__tests__/results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ describe('ResultsCommand tests', () => {
expect(fakeHttp.request).toHaveBeenCalledWith('get', {
args: {
cmd: 'get_results',
details: 1,
filter: ALL_FILTER.toFilterString(),
},
});
Expand Down Expand Up @@ -72,6 +73,7 @@ describe('ResultsCommand tests', () => {
expect(fakeHttp.request).toHaveBeenCalledWith('get', {
args: {
cmd: 'get_results',
details: 1,
},
});
const {data} = resp;
Expand Down
4 changes: 4 additions & 0 deletions gsa/src/gmp/commands/results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ export class ResultsCommand extends EntitiesCommand {
return root.get_results.get_results_response;
}

get(params = {}, options) {
return super.get({...params, details: 1}, options);
}

getDescriptionWordCountsAggregates({filter} = {}) {
return this.getAggregates({
aggregate_type: 'result',
Expand Down
2 changes: 1 addition & 1 deletion gsa/src/web/pages/notes/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ const NoteDialog = ({
name="result_uuid"
size="34"
disabled={state.result_id !== '0'}
value={state.result_uuid}
value={state.result_id}
onChange={onValueChange}
/>
)}
Expand Down