Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency "styled-components" #1441

Merged
merged 6 commits into from
Jun 17, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp self-assigned this Jun 14, 2019
@swaterkamp swaterkamp marked this pull request as ready for review June 14, 2019 12:02
@swaterkamp swaterkamp requested a review from a team June 14, 2019 12:02
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #1441 into master will increase coverage by <.01%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   36.75%   36.75%   +<.01%     
==========================================
  Files         985      985              
  Lines       22155    22158       +3     
  Branches     6109     6109              
==========================================
+ Hits         8142     8145       +3     
  Misses      12688    12688              
  Partials     1325     1325
Impacted Files Coverage Δ
gsa/src/web/components/dialog/dialog.js 43.75% <ø> (ø) ⬆️
gsa/src/web/components/layout/autosize.js 3.44% <ø> (ø) ⬆️
...rc/web/components/dashboard/display/datadisplay.js 7.47% <ø> (ø) ⬆️
gsa/src/web/components/chart/wordcloud.js 9.25% <ø> (ø) ⬆️
gsa/src/web/components/sortable/emptyrow.js 37.5% <ø> (ø) ⬆️
gsa/src/web/components/chart/donut/labels.js 27.27% <ø> (ø) ⬆️
gsa/src/web/components/chart/bar.js 11.68% <ø> (ø) ⬆️
gsa/src/web/components/chart/schedule.js 21.05% <ø> (ø) ⬆️
gsa/src/web/components/sortable/item.js 66.66% <ø> (ø) ⬆️
gsa/src/web/components/chart/bubble.js 15.78% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee9a0b...4ad7816. Read the comment docs.

Components now use children prop (previously render) and are adjusted to
new ref API
@bjoernricks bjoernricks merged commit d2941bb into greenbone:master Jun 17, 2019
@swaterkamp swaterkamp deleted the StyledCompDependency branch June 17, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants