Drop edit config command #1439
Merged
Drop edit config command #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the nvt families are loaded in get_config_gmp implicitly.
Extend the global gmp object to allow requesting the list of nvt families.
Simply request the scanconfig and the list of nvt families in parallel.
The command is unused now.
Now with get_nvt_families being an separate command get_config can be simplified by using get_one internally.
Due to using get_one in gsad the path to the scan config xml has changed.
The property is named maxNvtCount now.
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
+ Coverage 36.7% 36.75% +0.04%
==========================================
Files 984 985 +1
Lines 22156 22155 -1
Branches 6087 6087
==========================================
+ Hits 8133 8142 +9
+ Misses 12698 12688 -10
Partials 1325 1325
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of cmd=edit_config
Checklist: