LDAP and Radius improvements #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMP uses 0 for false and 1 for true in its api calls.
Add tests for saveLdap and savRadius to ensure the new behavior.
The constructor of the Settings class doesn't take any arguments.
Allow to check if a specific name is available in the settings.
With this new function it is easier to create generic responses for testing of command classes.
Als rename enable variable to enabled and add test for currentAuthSettings.
Update User, Ldap and Radius dialog to use bool values for enable.
Adjust textfield sizes at Radius dialog.
Simplify the code, use enabled instead of enable variable from settings, check if ldap and radius are enabled in gvm-libs and display text if they are disabled because of missing support in gvm-libs.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1437 +/- ##
===========================================
+ Coverage 37.09% 37.22% +0.12%
===========================================
Files 961 962 +1
Lines 21745 21761 +16
Branches 6027 6064 +37
===========================================
+ Hits 8067 8100 +33
+ Misses 12368 12355 -13
+ Partials 1310 1306 -4
Continue to review full report at Codecov.
|
sarahd93
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code paths for LDAP and Radius configurations.
References #1339
Checklist: