Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending related resources in permissions.create() #1432

Merged
merged 3 commits into from
May 29, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested a review from sarahd93 May 29, 2019 14:09
@swaterkamp swaterkamp requested a review from bjoernricks as a code owner May 29, 2019 14:09
@swaterkamp swaterkamp requested a review from a team May 29, 2019 14:09
@swaterkamp swaterkamp self-assigned this May 29, 2019
@swaterkamp swaterkamp merged commit 95ac11a into greenbone:gsa-8.0 May 29, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1432 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1432      +/-   ##
==========================================
+ Coverage    37.09%   37.1%   +<.01%     
==========================================
  Files          961     961              
  Lines        21744   21742       -2     
  Branches      6027    6025       -2     
==========================================
  Hits          8067    8067              
+ Misses       12367   12365       -2     
  Partials      1310    1310
Impacted Files Coverage Δ
gsa/src/gmp/commands/permissions.js 24.13% <0%> (ø) ⬆️
gsa/src/web/pages/portlists/dialog.js 17.39% <0%> (ø) ⬆️
gsa/src/web/pages/vulns/listpage.js 42.85% <0%> (ø) ⬆️
gsa/src/web/pages/targets/dialog.js 20.28% <0%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4909e7e...057fd86. Read the comment docs.

@swaterkamp swaterkamp deleted the TaskPermissiosn branch February 20, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants