Fast xml parser encoding #1414
Merged
Fast xml parser encoding #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead add a status getter to the Rejection class.
Setting the responseType doesn't work after the xhr request has already finished. Therefore extend plainText method to allow to return the original response as text.
Add the same plainData method to Rejection class as in Response.
Extract common xml transformation code into an own module.
Simplify x2js and fastxml trasnfrom modules by using the new xml module.
Finally fix all xml encoding issues when using the fastxml transform. This will allow to use the fastxml transform as default in future.
This has become obsolete with the fastxml transform doing the decoding automatically.
It's not necessary to keep the copied values in the envelope.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1414 +/- ##
===========================================
+ Coverage 36.68% 36.82% +0.14%
===========================================
Files 960 961 +1
Lines 21741 21737 -4
Branches 6017 6042 +25
===========================================
+ Hits 7975 8004 +29
+ Misses 12435 12410 -25
+ Partials 1331 1323 -8
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix decoding of xml entities with fast-xml-parser
Checklist: