Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change checkboxes for solution types to radio buttons #1398

Merged
merged 8 commits into from
May 13, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review May 13, 2019 13:39
@sarahd93 sarahd93 requested a review from a team May 13, 2019 13:39
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #1398 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1398      +/-   ##
===========================================
- Coverage    36.39%   36.38%   -0.01%     
===========================================
  Files          960      960              
  Lines        21657    21658       +1     
  Branches      6018     6019       +1     
===========================================
  Hits          7881     7881              
- Misses       12444    12445       +1     
  Partials      1332     1332
Impacted Files Coverage Δ
...rc/web/components/powerfilter/solutiontypegroup.js 6.25% <0%> (-0.42%) ⬇️
gsa/src/web/components/form/radio.js 100% <100%> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 3.26% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c9930...9a8b079. Read the comment docs.

@sarahd93 sarahd93 requested a review from bjoernricks May 13, 2019 13:58
@bjoernricks bjoernricks merged commit 70fe54d into greenbone:gsa-8.0 May 13, 2019
@sarahd93 sarahd93 deleted the solutiontypegroup_radio_gsa8 branch May 13, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants