Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EditScanConfigDialog performance #1388

Merged
merged 3 commits into from
May 10, 2019

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented May 10, 2019

  • Fold the last two Sections in EditScanConfigDialog
  • Add counters to Section title to indicate that there are indeed things to see
  • Remove Styles from within .svg-Icons

Checklist:

@swaterkamp swaterkamp self-assigned this May 10, 2019
@swaterkamp swaterkamp marked this pull request as ready for review May 10, 2019 10:13
@swaterkamp swaterkamp requested a review from a team May 10, 2019 10:13
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1388 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1388      +/-   ##
===========================================
+ Coverage    36.15%   36.15%   +<.01%     
===========================================
  Files          960      960              
  Lines        21652    21651       -1     
  Branches      5992     6017      +25     
===========================================
  Hits          7828     7828              
+ Misses       12488    12486       -2     
- Partials      1336     1337       +1
Impacted Files Coverage Δ
gsa/src/web/pages/scanconfigs/editdialog.js 8.77% <16.66%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178d0f6...d04fc55. Read the comment docs.

@bjoernricks bjoernricks merged commit b2a94e3 into greenbone:gsa-8.0 May 10, 2019
@swaterkamp swaterkamp deleted the ScanConfigDialogPerformance branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants