Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled task tooltip time format #1382

Merged
merged 3 commits into from
May 9, 2019

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented May 9, 2019

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review May 9, 2019 13:08
@sarahd93 sarahd93 requested a review from a team May 9, 2019 13:08
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1382 into gsa-8.0 will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0    #1382     +/-   ##
==========================================
- Coverage     36.1%   36.01%   -0.1%     
==========================================
  Files          960      959      -1     
  Lines        21676    21643     -33     
  Branches      6013     5978     -35     
==========================================
- Hits          7827     7795     -32     
  Misses       12513    12513             
+ Partials      1336     1335      -1
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/icons/scheduleicon.js 16.66% <100%> (+4.9%) ⬆️
gsa/src/web/routes.js 30.76% <0%> (-52.57%) ⬇️
gsa/src/web/pages/reportformats/row.js 33.33% <0%> (-6.67%) ⬇️
gsa/src/web/authorized.js 3.7% <0%> (-4.87%) ⬇️
gsa/src/web/components/bar/menubar.js 6.52% <0%> (-1.01%) ⬇️
gsa/src/web/components/bar/titlebar.js 77.27% <0%> (-0.99%) ⬇️
gsa/src/web/store/usersettings/actions.js 100% <0%> (ø) ⬆️
gsa/src/web/app.js 0% <0%> (ø) ⬆️
gsa/src/web/store/usersettings/selectors.js 100% <0%> (ø) ⬆️
gsa/src/web/store/usersettings/reducers.js 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f119368...d5847be. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes May 9, 2019
@bjoernricks bjoernricks merged commit 1034ec7 into greenbone:gsa-8.0 May 9, 2019
@sarahd93 sarahd93 deleted the tooltip_time_format_gsa8 branch May 9, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants