Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve login page #1347

Merged
merged 4 commits into from
May 2, 2019
Merged

Improve login page #1347

merged 4 commits into from
May 2, 2019

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented May 2, 2019

Checklist:

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #1347 into gsa-8.0 will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1347      +/-   ##
===========================================
- Coverage    34.79%   34.72%   -0.08%     
===========================================
  Files          959      959              
  Lines        21628    21597      -31     
  Branches      5967     5978      +11     
===========================================
- Hits          7526     7500      -26     
+ Misses       12760    12756       -4     
+ Partials      1342     1341       -1
Impacted Files Coverage Δ
gsa/src/web/components/structure/footer.js 75% <ø> (ø) ⬆️
gsa/src/web/pages/login/loginpage.js 17.46% <ø> (ø) ⬆️
gsa/src/web/pages/login/loginform.js 87.5% <100%> (-0.6%) ⬇️
gsa/src/web/components/table/table.js 81.81% <0%> (-9.1%) ⬇️
gsa/src/web/store/entities/dfncerts.js 100% <0%> (ø) ⬆️
gsa/src/web/store/entities/permissions.js 100% <0%> (ø) ⬆️
gsa/src/web/store/entities/cpes.js 100% <0%> (ø) ⬆️
gsa/src/web/store/entities/scanconfigs.js 100% <0%> (ø) ⬆️
gsa/src/web/store/entities/overrides.js 100% <0%> (ø) ⬆️
gsa/src/web/store/entities/agents.js 100% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a286596...002e274. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes May 2, 2019
@bjoernricks bjoernricks self-requested a review May 2, 2019 14:33
@sarahd93 sarahd93 marked this pull request as ready for review May 2, 2019 14:34
@sarahd93 sarahd93 requested a review from swaterkamp as a code owner May 2, 2019 14:34
@sarahd93 sarahd93 requested a review from a team May 2, 2019 14:34
bjoernricks
bjoernricks previously approved these changes May 2, 2019
@bjoernricks bjoernricks merged commit 7facf5a into greenbone:gsa-8.0 May 2, 2019
@sarahd93 sarahd93 deleted the login_page_gsa8 branch May 2, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants