Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tool tips to credential download icons #1335

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Add missing tool tips to credential download icons #1335

merged 2 commits into from
Apr 29, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 changed the title Add missing tooltips to credential download icons Add missing tool tips to credential download icons Apr 29, 2019
@sarahd93 sarahd93 marked this pull request as ready for review April 29, 2019 14:50
@sarahd93 sarahd93 requested a review from a team April 29, 2019 14:50
@bjoernricks bjoernricks merged commit 4ac63e4 into greenbone:gsa-8.0 Apr 29, 2019
@sarahd93 sarahd93 deleted the credential_gsa8 branch April 29, 2019 15:01
swaterkamp
swaterkamp requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like as if the titles from the Icons themselves don't work properly. Could you fix those instead, or remove setting the title in the components? see downloaddebicon.js as example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp requested changes

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahd93 @bjoernricks @swaterkamp