Consider timezone when using durations for performance #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the performance timeline is calculated from a duration also consider the current user timezone.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1329 +/- ##
===========================================
- Coverage 34.41% 34.41% -0.01%
===========================================
Files 959 959
Lines 21578 21579 +1
Branches 5950 5950
===========================================
Hits 7426 7426
- Misses 12798 12799 +1
Partials 1354 1354
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the performance timeline is calculated from a duration also consider
the current user timezone.
Checklist: