Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert filter issues #1315

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Alert filter issues #1315

merged 3 commits into from
Apr 25, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 25, 2019 •
edited
Loading

Fix creating and editing of alerts

Checklist:

@bjoernricks
Fix saving an existing alert without filter_id
7076780 
Allow to skip passing a filter_id parameter to save_filter in gsad.
@bjoernricks
Allow to create a new filter without a filter_id
cbf332b 
Don't get a "Given filter_id was invalid" message from gvmd.
@bjoernricks
Add changelog entry for alert filter fixes
c73fc79
@bjoernricks bjoernricks marked this pull request as ready for review April 25, 2019 14:49
@bjoernricks bjoernricks requested a review from a team April 25, 2019 14:49
@swaterkamp swaterkamp merged commit dbe0932 into greenbone:gsa-8.0 Apr 25, 2019
@bjoernricks bjoernricks deleted the alert-filter-issues branch April 25, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

@timopollmeier timopollmeier Awaiting requested review from timopollmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp