Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter in Report Results view cannot be saved #1303

Merged
merged 5 commits into from
Apr 24, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1303 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1303      +/-   ##
===========================================
- Coverage    18.09%   18.09%   -0.01%     
===========================================
  Files          953      953              
  Lines        27716    27721       +5     
  Branches      6000     6002       +2     
===========================================
  Hits          5015     5015              
- Misses       21296    21301       +5     
  Partials      1405     1405
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailsfilterdialog.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/scanners/component.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1125329...5284aed. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review April 24, 2019 10:37
@sarahd93 sarahd93 requested a review from a team April 24, 2019 10:37
@sarahd93 sarahd93 force-pushed the report_results_filter_gsa8 branch from 542c508 to 71d1072 Compare April 24, 2019 10:53
@swaterkamp swaterkamp merged commit edd0aee into greenbone:gsa-8.0 Apr 24, 2019
@sarahd93 sarahd93 deleted the report_results_filter_gsa8 branch April 24, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants