Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detailslinks in AllSecInfo #1299

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1299 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1299      +/-   ##
===========================================
- Coverage    18.08%   18.08%   -0.01%     
===========================================
  Files          953      953              
  Lines        27727    27731       +4     
  Branches      6008     6010       +2     
===========================================
  Hits          5015     5015              
- Misses       21305    21309       +4     
  Partials      1407     1407
Impacted Files Coverage Δ
gsa/src/web/pages/secinfo/table.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/scanconfigs/editdialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d22485...2267d97. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1299 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1299      +/-   ##
===========================================
- Coverage    18.08%   18.08%   -0.01%     
===========================================
  Files          953      953              
  Lines        27727    27731       +4     
  Branches      6008     6010       +2     
===========================================
  Hits          5015     5015              
- Misses       21305    21309       +4     
  Partials      1407     1407
Impacted Files Coverage Δ
gsa/src/web/pages/secinfo/table.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/scanconfigs/editdialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d22485...5193fdf. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review April 23, 2019 09:50
@sarahd93 sarahd93 requested a review from a team April 23, 2019 09:50
@bjoernricks bjoernricks merged commit cd513e3 into greenbone:gsa-8.0 Apr 23, 2019
@sarahd93 sarahd93 deleted the detailslinks_gsa8 branch April 23, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants