Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialog can be moved outside browser frame #1294

Merged
merged 2 commits into from
Apr 18, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1294 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1294      +/-   ##
===========================================
- Coverage    18.08%   18.08%   -0.01%     
===========================================
  Files          953      953              
  Lines        27726    27728       +2     
  Branches      6001     6010       +9     
===========================================
  Hits          5014     5014              
- Misses       21305    21307       +2     
  Partials      1407     1407
Impacted Files Coverage Δ
gsa/src/web/components/dialog/dialog.js 43.75% <0%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e2b5f...b05a799. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review April 17, 2019 14:49
@sarahd93 sarahd93 requested a review from a team April 17, 2019 14:49
@bjoernricks bjoernricks merged commit a5b2e95 into greenbone:gsa-8.0 Apr 18, 2019
@sarahd93 sarahd93 deleted the dialog_gsa8 branch April 18, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants