Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port ranges from file radio button #1291

Merged
merged 3 commits into from
Apr 17, 2019

Conversation

sarahd93
Copy link
Contributor

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review April 17, 2019 09:25
@sarahd93 sarahd93 requested a review from a team April 17, 2019 09:25
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #1291 into gsa-8.0 will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1291      +/-   ##
===========================================
- Coverage    18.08%   18.03%   -0.05%     
===========================================
  Files          953      953              
  Lines        27723    27683      -40     
  Branches      6006     5991      -15     
===========================================
- Hits          5013     4994      -19     
+ Misses       21303    21284      -19     
+ Partials      1407     1405       -2
Impacted Files Coverage Δ
gsa/src/web/pages/portlists/dialog.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/table.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/container.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/listpage.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/filter/convert.js 100% <0%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <0%> (ø) ⬆️
gsa/src/gmp/gmpsettings.js 100% <0%> (ø) ⬆️
gsa/src/web/components/powerfilter/powerfilter.js 0% <0%> (ø) ⬆️
gsa/src/web/components/img/product.js 100% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41df22f...2ddaa94. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Apr 17, 2019
@bjoernricks bjoernricks merged commit 6fc3909 into greenbone:gsa-8.0 Apr 17, 2019
@sarahd93 sarahd93 deleted the port-ranges_gsa8 branch April 17, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants