Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start reload timer if a timer is already running #1289

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Don't start reload timer if a timer is already running #1289

merged 3 commits into from
Apr 17, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 16, 2019

Avoid running multiple timers for the same page. This could happen
before when changing the filter while a timer was running.

Checklist:

Avoid running multiple timers for the same page. This could happen
before when changing the filter while a timer was running.
@bjoernricks bjoernricks marked this pull request as ready for review April 16, 2019 15:00
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner April 16, 2019 15:00
@bjoernricks bjoernricks requested a review from a team April 16, 2019 15:00
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #1289 into gsa-8.0 will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1289      +/-   ##
===========================================
- Coverage    18.08%   18.05%   -0.03%     
===========================================
  Files          953      953              
  Lines        27723    27689      -34     
  Branches      6006     5985      -21     
===========================================
- Hits          5013     4999      -14     
+ Misses       21303    21285      -18     
+ Partials      1407     1405       -2
Impacted Files Coverage Δ
gsa/src/web/entity/container.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/container.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/table.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/listpage.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/filter/convert.js 100% <0%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <0%> (ø) ⬆️
gsa/src/web/components/powerfilter/powerfilter.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac1e5b...b249481. Read the comment docs.

@bjoernricks bjoernricks merged commit 41df22f into greenbone:gsa-8.0 Apr 17, 2019
@bjoernricks bjoernricks deleted the avoid-running-multiple-timers branch April 17, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants