Filter fixes #1288
Merged
Filter fixes #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1288 +/- ##
===========================================
+ Coverage 18.05% 18.08% +0.02%
===========================================
Files 953 953
Lines 27689 27723 +34
Branches 5994 6006 +12
===========================================
+ Hits 4999 5013 +14
- Misses 21285 21303 +18
- Partials 1405 1407 +2
Continue to review full report at Codecov.
|
When paging through the list of reports and selecting a report for delta comparision always reset the pagination to the first page. If not reset the list for selecting the report for diff comparision could be empty.
Most methods of Filter model are mutable. If a filter has an id and a filter is changed the id doesn't reflect the original fiter anymore. Therefore it must be reset. This fixes the pagination at the list tables if a default filter is applied.
The method isn't used outside of Filter model. Therefore it should be kept private.
Remove the current applied filter from the state of the Powerfilter. Only store the previously applied filter to allow updating the filter input field. With this change the filter in the Powerfilter component is controlled from the outside completely.
If reset or remove icons are clicked reset the displayed user filter string at the input field in the powerfilter.
Using filter keyword with quotes like foo="bar" creates xml escaped values when using the fastxml parser. Therefore the values need to be unescaped before being evaluated and converted. This is e.g. an issue at the report details page when adding result filters.
First improve the style by adding some margins and second always display the current applied filter. This allows to take a look at the applied filter when the filtering doesn't return any entities.
Avoid displaying an empty list page when the first filter value exceeds the number of available entities. In that case reset the first filter value to 1 and do a reload of the page.
Decode xml encoded filter relations too. Releations can be > and < which are encoded as > and < by fast-xml-parser.
swaterkamp
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several issues with filter handling
Checklist: