Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer UX concerning (saving) filters #1268

Merged
merged 4 commits into from
Apr 10, 2019

Conversation

swaterkamp
Copy link
Member

Checklist:

  • [ N/A ] Tests
  • [ X ] CHANGES Entry

@swaterkamp swaterkamp self-assigned this Apr 9, 2019
@swaterkamp swaterkamp requested review from bjoernricks and a team April 9, 2019 15:05
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #1268 into gsa-8.0 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           gsa-8.0    #1268   +/-   ##
========================================
  Coverage    17.86%   17.86%           
========================================
  Files          952      952           
  Lines        27655    27655           
  Branches      5971     5980    +9     
========================================
  Hits          4940     4940           
  Misses       21305    21305           
  Partials      1410     1410
Impacted Files Coverage Δ
gsa/src/web/components/form/checkbox.js 100% <ø> (ø) ⬆️
gsa/src/web/components/dialog/composercontent.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/alerts/contentcomposerdialog.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/triggeralertdialog.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/reports/downloadreportdialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802dfd4...ed4a070. Read the comment docs.

@bjoernricks bjoernricks merged commit 7de9bae into greenbone:gsa-8.0 Apr 10, 2019
@swaterkamp swaterkamp deleted the ComposerUX branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants