Cleanup gsad #1265
Merged
Cleanup gsad #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guest user support is implemented in GSA now. There is no need for extra code in gsad anymore. This commit removes the following CLI arguments: * --http-guest-chart-frame-opts * --http-guest-chart-csp * --guest-username * --guest-password
This is a left over from GSA 7. The commit removed the --login-lable CLI argument.
Allow for easier handling of the copyright displayed with the --version switch.
If gsa isn't build from a git clone don't set the GIT_REVISION variable.
The git revision is included in the GSAD_VERSION variable automatically. There is no need to set a define, generate an extra header or something else.
wiegandm
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1258
Checklist: