About page fixes #1264
Merged
About page fixes #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the version into a constant variable an only show major.minor version number. We need to generate this version automatically from some configuration file in future...
GVM 10 provides GMP version 8. Also use https url. Fixes #1262
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1264 +/- ##
===========================================
- Coverage 17.86% 17.85% -0.01%
===========================================
Files 952 952
Lines 27653 27654 +1
Branches 5971 5980 +9
===========================================
Hits 4939 4939
- Misses 21304 21305 +1
Partials 1410 1410
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version and link to protocol docs at about page
Checklist: