Cleanup get_report function in gsad #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused code paths from get_report function in gsad. Most of this original code has become obsolete with GSA 8. It was required to pass arbitrary parameters to the XSLT transformation in GSA 7.
no_redirect and next parameters aren't interpreted by gsad anymore.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1263 +/- ##
===========================================
+ Coverage 17.85% 17.86% +<.01%
===========================================
Files 952 952
Lines 27654 27653 -1
Branches 5980 5980
===========================================
Hits 4939 4939
+ Misses 21305 21304 -1
Partials 1410 1410
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused code paths from get_report function in gsad. Most of this
original code has become obsolete with GSA 8. It was required to pass
arbitrary parameters to the XSLT transformation in GSA 7.
Checklist: