New task single requests #1220
Merged
New task single requests #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1220 +/- ##
===========================================
+ Coverage 16.79% 17.18% +0.39%
===========================================
Files 950 950
Lines 27609 27566 -43
Branches 5939 5940 +1
===========================================
+ Hits 4637 4738 +101
+ Misses 21504 21376 -128
+ Partials 1468 1452 -16
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Mar 21, 2019
Avoid using the newTaskSettings command to load the alerts and default alert id. Instead load them from the store.
Either store the actual value of the setting or use undefined if it isn't set. There should only be one meaning of not set and that's using undefined.
Pass onInteraction handler down to other component in TaskComponent. This will extend the user session when opening a sub dialog e.g. to create a new alert.
Don't use the schedules from the newTaskSettings request. Instead load the Schedules from the redux store.
The create_container_task command is envisaged for creating container tasks.
Allow to test the default model methods seperately from the model properties.
Only set known and allowed values for host ordering.
Update TaskCommand to use a default for host_ordering when saving a task.
Allow access to original data when parsing a task.
It's hosts_ordering and not host_ordering. Update constants accordingly.
Import the default hosts ordering from task model module.
The box prop has been removed a long time ago from the Layout component. This removes a unknown prop warning raised by react.
Don't allow to select a tag if the add tag checkbox is not checked.
It doesn't make sense to add a tag when editing a task. It is even not implemented in gsad.
Select the first tag from the tag selection list automatically when opening the new TaskDialog.
Don't require to pass the sorted list of scan configs to the TaskDialog. Instead sort the list within the dialog an pass the sorted list to the scanner/scan config selection component.
Don't apply row filter defaults. Instead query all alerts, schedules and targets.
When opening a new TaskDialog load the list of tags from the redux store.
Don't use the targets from the edit task settings response. We are loading the list of targets from the redux store now.
Load the available scan configs and scanners from the redux store when opening the TaskDialog.
Add a special handler method for saving a task that checks if the task has to be created or modified, checks if the task is changeable/alterable, resets target, config and scanner id and closes the dialog afterwards. Normally and also as it was done before the correct ids are set when OPENING the dialog already. But with loading the possible values from the redux store and the api complexity this doesn't work anymore.
The scan configs are already used from the redux store and not from the state.
Running a task on a slave via the advanced task dialog has removed some time ago already.
The box prop got removed a long time ago. This change removes a react invalid prop warning.
credentials and scan_configs props of AdvancedTaskWizard expect both an array of models.
It's already possible to set schedule to run only once at the task dialog. But the value was never passed to gsad.
Update handleSaveTask method in TaskComponent to pass the arguments to save and create task commands explicitly. With this change it will be more obvious what's being expected and passed to each command.
Converting to the correct defaults should be done at the command level and not at the dialogs or entity components. If a value is not defined it should be undefined instead of 0, '' or '0'.
When saving a task allow to modify the schedule_periods. The schedule_periods are used to run a schedule only once.
Rename AUTO_DELETE_DEFAULT_VALUE to AUTO_DELETE_KEEP_DEFAULT_VALUE to avoid confusion about the meaning of the default.
This allows to get form fields more easily. Don't know why it isn't provided by dom-testing-library already.
In GSA 7 the default has been not to delete any report of a task. We should keep the same default.
swaterkamp
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: