Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to sort scan config nvts in edit dialog #1210

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Allow to sort scan config nvts in edit dialog #1210

merged 2 commits into from
Mar 13, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Mar 13, 2019

Allow to sort the nvts at the edit scan config families dialog by name,
oid, severity, timeout and selected. Sorting by selected is a bit
"hackish" because the selected information isn't contained in the nvts
array.

Checklist:

Allow to sort the nvts at the edit scan config families dialog by name,
oid, severity, timeout and selected. Sorting by selected is a bit
"hackish" because the selected information isn't contained in the nvts
array.
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner March 13, 2019 14:29
@bjoernricks bjoernricks requested a review from a team March 13, 2019 14:31
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #1210 into gsa-8.0 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1210      +/-   ##
===========================================
- Coverage     16.5%   16.48%   -0.02%     
===========================================
  Files          948      948              
  Lines        27610    27641      +31     
  Branches      5925     5932       +7     
===========================================
  Hits          4558     4558              
- Misses       21594    21611      +17     
- Partials      1458     1472      +14
Impacted Files Coverage Δ
...rc/web/pages/scanconfigs/editconfigfamilydialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc014db...07fd179. Read the comment docs.

@swaterkamp swaterkamp merged commit 08b1121 into greenbone:gsa-8.0 Mar 13, 2019
@bjoernricks bjoernricks deleted the sort-scan-config-nvts branch March 13, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants