Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow percent signs in tag values and add CHANGES entry #1145

Merged
merged 3 commits into from
Jan 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ $ cd gsa && git log
* Sort alerts at task details alphanumerically #1094
* Add solution type to report details powerfilter #1091
* Add feature: Scan Report Content Composer #1073 #1084 #1086 #1090
* Tags can now contain backslashes and percent signs in the value and
hyphens in the name to allow using the special "smb-alert:file_path"
task tag #1107 #1142 #1145


## gsa 8.0+beta2 (2018-12-04)

Expand Down
2 changes: 1 addition & 1 deletion gsad/src/gsad.c
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ init_validator ()
gvm_validator_add (validator, "summary", "^.{0,400}$");
gvm_validator_add (validator, "tag_id", "^[a-z0-9\\-]+$");
gvm_validator_add (validator, "tag_name", "^[\\:\\-_[:alnum:], \\./]{1,80}$");
gvm_validator_add (validator, "tag_value", "^[\\-_@[:alnum:], \\.\\\\]{0,200}$");
gvm_validator_add (validator, "tag_value", "^[\\-_@%[:alnum:], \\.\\\\]{0,200}$");
gvm_validator_add (validator, "target_id", "^[a-z0-9\\-]+$");
gvm_validator_add (validator, "task_id", "^[a-z0-9\\-]+$");
gvm_validator_add (validator, "term", "^.{0,1000}");
Expand Down