Alert encrypt email #1070
Merged
Alert encrypt email #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the recipient_credential for an email alert is set and not "0" send it to gvmd.
When modiyfing and creating an alert pass the recipient_credential method data to gsad.
When displaying the details of an alert with email method display a link to the credential used for encryption. Currently the name of the credential isn't been shown because the name isn't included and must be queried from the backend additionally.
Diffentiate between sending an encrypted and not encrypted email when displaying the method type for an email alert at the alert list page.
Allow to select a smime or pgp credential for email encryption in alerts.
Update Alert component to allow creating and changing a credential for encrypting emails when sending an alert.
|
Closes #916 |
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
- Coverage 13.77% 13.76% -0.01%
==========================================
Files 823 823
Lines 26689 26713 +24
Branches 5609 5628 +19
==========================================
+ Hits 3677 3678 +1
- Misses 21560 21582 +22
- Partials 1452 1453 +1
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to encrypt emails send by alerts via setting a pgp or smime credential.