Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error boundaries #1046

Merged
merged 15 commits into from
Nov 7, 2018
Merged

Error boundaries #1046

merged 15 commits into from
Nov 7, 2018

Conversation

swaterkamp
Copy link
Member

Add new ErrorBoundary component and use it where seemingly appropriate.

@swaterkamp swaterkamp self-assigned this Nov 7, 2018
@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #1046 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   13.49%   13.47%   -0.02%     
==========================================
  Files         820      821       +1     
  Lines       26605    26641      +36     
  Branches     5615     5606       -9     
==========================================
  Hits         3590     3590              
- Misses      21565    21599      +34     
- Partials     1450     1452       +2
Impacted Files Coverage Δ
gsa/src/web/components/dashboard/dashboard.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/extras/feedstatuspage.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/radius/radiuspage.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/extras/trashcanpage.js 0% <0%> (ø) ⬆️
.../src/web/components/errorboundary/errorboundary.js 0% <0%> (ø)
gsa/src/web/pages/help/about.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/extras/cvsscalculatorpage.js 0% <0%> (ø) ⬆️
gsa/src/web/app.js 0% <0%> (ø) ⬆️
...sa/src/web/components/dashboard/display/display.js 0% <0%> (ø) ⬆️
gsa/src/web/entities/page.js 0% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddb5ef...c1b5e34. Read the comment docs.

@swaterkamp swaterkamp merged commit 0d104b9 into greenbone:master Nov 7, 2018
@swaterkamp swaterkamp deleted the ErrorBoundaries branch November 7, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants