GUI miscellaneous #6 #1030
Merged
GUI miscellaneous #6 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives isWritable() a higher priority than isInUse()
Ultimately Spinner expects a number but received a string
bjoernricks
requested changes
Oct 22, 2018
| @@ -304,8 +309,8 @@ class AlertComponent extends React.Component { | |||
| condition_data_at_least_filter_id: condition_data_filter_id, | |||
| condition_data_at_least_count: parseInt( | |||
| value(condition.data.count, 1)), | |||
| condition_data_severity: value(condition.data.severity, | |||
| DEFAULT_SEVERITY), | |||
| condition_data_severity: parseFloat(value(condition.data.severity, | |||
There was a problem hiding this comment.
would be better to user parseSeverity instead of parseFloat
bjoernricks
approved these changes
Oct 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 11.42% 11.42%
=======================================
Files 820 820
Lines 26603 26603
Branches 5600 5600
=======================================
Hits 3039 3039
Misses 22005 22005
Partials 1559 1559
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.