GUI miscellaneous #5 #1025
Merged
GUI miscellaneous #5 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
swaterkamp
commented
Oct 17, 2018
swaterkamp
commented
- Fix table alignments
- Change things for Task details and listpage
- Change things for Reports table
- Add link to family-filtered NVTS on ScanConfig detailspage
Codecov Report
@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 10.34% 10.34% -0.01%
==========================================
Files 820 820
Lines 26737 26739 +2
Branches 5617 5616 -1
==========================================
Hits 2766 2766
- Misses 22380 22382 +2
Partials 1591 1591
Continue to review full report at Codecov.
|
bjoernricks
previously approved these changes
Oct 17, 2018
"Total" is renamed to "Reports", old "reports" row is removed.
The count for unfinished reports is removed and only the total is shown (including unfinished ones).
The "Finished Reports" icon got removed. The "Last Report" icon is shown in case there is no "Current Report" (actively running). If there is no current and no last report, no icon is shown.
bjoernricks
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.