Improve entity tags and permissions table layout #1021
Conversation
swaterkamp
commented
Oct 12, 2018
swaterkamp
commented
- Center Actions column
- Remove toggleDetailsIcon from permissions tab
gsa/src/web/entity/tags.js
Outdated
| /> | ||
| </IconDivider> | ||
| <TableData align="center"> | ||
| <span> |
There was a problem hiding this comment.
Is the span really necessary? At least it shouldn't.
There was a problem hiding this comment.
It shouldn't, but it is. The IconDivider was not centered without the span.
There was a problem hiding this comment.
Did you try setting the align at the IconDivider?
There was a problem hiding this comment.
Yes, I did, but it didn't work. What I did not test, though, is to set the IconDivider to grow. A growing divider plus the align="center" in its tag solves the issue.
Also adjust Actions column width
However: The margin on top of the table does not collapse and it seem like there is an invisible pagination component somewhere. Needs to be found and fixed in the future.
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
=========================================
+ Coverage 9.5% 9.51% +0.01%
=========================================
Files 820 820
Lines 26650 26615 -35
Branches 5621 5606 -15
=========================================
Hits 2533 2533
+ Misses 22499 22466 -33
+ Partials 1618 1616 -2
Continue to review full report at Codecov.
|
