Skip to content

Commit

Permalink
Merge pull request #3125 from greenbone/mergify/bp/master/pr-3124
Browse files Browse the repository at this point in the history
[AP1032] Show dead hosts as possible reason in empty report when scan finishes (backport #3124)
  • Loading branch information
swaterkamp authored Aug 6, 2021
2 parents b4920ba + 13169a5 commit 4b82714
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 8 deletions.
16 changes: 14 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

[21.04]: https://github.com/greenbone/gsa/compare/gsa-20.08...v21.04.0

## [20.8.3] (unreleased)
## [20.8.4] (unreleased)

### Added
### Changed
### Deprecated
### Removed
### Fixed
- Show dead hosts as possible reason in empty report when scan finishes [#3124](https://github.com/greenbone/gsa/pull/3124)

[Unreleased]: https://github.com/greenbone/gsa/compare/v20.8.3...gsa-20.08

## [20.8.3] 2021-08-03

### Added
### Changed
Expand All @@ -137,9 +148,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Deprecated
### Removed
### Fixed
- Show dead hosts as possible reason in empty report when scan finishes [#3124](https://github.com/greenbone/gsa/pull/3124)
- Fixed setting/displaying timeout in EditNvtDetailsDialog [#3057](https://github.com/greenbone/gsa/pull/3057)

[Unreleased]: https://github.com/greenbone/gsa/compare/v20.8.2...gsa-20.08
[20.8.3]: https://github.com/greenbone/gsa/compare/v20.8.2...gsa-20.08

## [20.8.2] - 2021-06-25

Expand Down
28 changes: 22 additions & 6 deletions gsa/src/web/pages/reports/details/emptyreport.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,28 @@ const EmptyReport = ({
/>
<Divider wrap>
{!isActiveReport && (
<ReportPanel
icon={props => <TaskIcon {...props} />}
title={_('The scan did not collect any results')}
>
{_('If the scan got interrupted you can try to re-start the task.')}
</ReportPanel>
<React.Fragment>
<ReportPanel
icon={props => <TaskIcon {...props} />}
title={_('The scan did not collect any results')}
>
{_(
'If the scan got interrupted you can try to re-start the task.',
)}
</ReportPanel>
<ReportPanel
icon={props => <TargetIcon {...props} />}
title={_('The target hosts could be regarded dead')}
onClick={may_edit_target ? onTargetEditClick : undefined}
>
{_(
'You should change the Alive Test Method of the ' +
'target for the next scan. However, if the target hosts ' +
'are indeed dead, the scan duration might increase ' +
'significantly.',
)}
</ReportPanel>
</React.Fragment>
)}
{isActiveReport && progress === 1 && (
<ReportPanel
Expand Down

0 comments on commit 4b82714

Please sign in to comment.